Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Revert "App Update (EXPOSUREAPP-8905)" #4194

Merged
merged 9 commits into from
Oct 12, 2021
Merged

Revert "App Update (EXPOSUREAPP-8905)" #4194

merged 9 commits into from
Oct 12, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Oct 11, 2021 •
edited
Loading

Reverts #4046

This PR is reverting - In-App-Update feature as discussed here

@mtwalli mtwalli added bug Something isn't working maintainers Tag pull requests created by maintainers labels Oct 11, 2021
@mtwalli mtwalli added this to the 2.11.0 milestone Oct 11, 2021
@mtwalli mtwalli requested a review from a team October 11, 2021 13:37
@Bubu
Copy link
Contributor

Bubu commented Oct 11, 2021

Is it possible to see the discussion about this? (Mostly just curious, but the feature does touch our CCTG fork as we needed to remove the google dependency here.)

@mtwalli
Copy link
Contributor Author

mtwalli commented Oct 11, 2021

Is it possible to see the discussion about this? (Mostly just curious, but the feature does touch our CCTG fork as we needed to remove the google dependency here.)

Unfortunately the discussion is in internal ticket, but you can review users feedback on Google play. it put them in an awkward situation where connectivity is bad and they are in urgent need to show their Certificates

@mtwalli mtwalli added the prio PRs to review first. label Oct 11, 2021
BMItr
BMItr previously approved these changes Oct 11, 2021
View reviewed changes
BMItr
BMItr previously approved these changes Oct 11, 2021
View reviewed changes
chiljamgossow
chiljamgossow previously approved these changes Oct 11, 2021
View reviewed changes
@chiljamgossow chiljamgossow self-assigned this Oct 11, 2021
@mtwalli mtwalli added author merge PR to be merged by author do not merge labels Oct 11, 2021
@mtwalli mtwalli marked this pull request as draft October 11, 2021 14:43
@Bubu
Copy link
Contributor

Bubu commented Oct 11, 2021

it put them in an awkward situation where connectivity is bad and they are in urgent need to show their Certificates

I see, thanks for the explanation. 👍

@mtwalli mtwalli changed the base branch from release/2.11.x to release/2.12.x October 12, 2021 07:49
@mtwalli mtwalli dismissed stale reviews from chiljamgossow and BMItr October 12, 2021 07:49

The base branch was changed.

@mtwalli mtwalli modified the milestones: 2.11.0, 2.12.0 Oct 12, 2021
@mtwalli
Merge branch 'release/2.12.x' into revert-4046-feature/8905-force-update
b6a2a34 
# Conflicts:
#	Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/launcher/LauncherActivityTest.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/launcher/LauncherActivity.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/launcher/LauncherActivityViewModel.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/launcher/LauncherEvent.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/di/ApplicationComponent.kt
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/launcher/LauncherActivityViewModelTest.kt
#	gradle.properties
@mtwalli
Resolve merge issues
d159c28
@mtwalli
Update LauncherActivityViewModelTest.kt
bf3d286
@mtwalli mtwalli marked this pull request as ready for review October 12, 2021 08:54
@mtwalli mtwalli removed do not merge author merge PR to be merged by author labels Oct 12, 2021
BMItr
BMItr approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retested on Pixel 2 & Oneplus 8 device.
Root Check also working.
lgtm.

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.4% 79.4% Coverage
0.0% 0.0% Duplication

chiljamgossow
chiljamgossow approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested root detection on Nexus 5, lgtm

@mtwalli mtwalli merged commit 5e60998 into release/2.12.x Oct 12, 2021
@mtwalli mtwalli deleted the revert-4046-feature/8905-force-update branch October 12, 2021 13:11
@MikeMcC399 MikeMcC399 mentioned this pull request Oct 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chiljamgossow chiljamgossow chiljamgossow approved these changes

@BMItr BMItr BMItr approved these changes

Assignees

@BMItr BMItr

@chiljamgossow chiljamgossow

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtwalli @Bubu @BMItr @chiljamgossow @Corona-Warn-App-Technical-User