Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Personal Certificate data in error Report available (EXPOSUREAPP-9923) #4195

Merged
merged 8 commits into from
Oct 12, 2021
Merged

Personal Certificate data in error Report available (EXPOSUREAPP-9923) #4195

merged 8 commits into from
Oct 12, 2021

Conversation

jurajkusnier
Copy link
Contributor

Testing

  • App Info > Error Reports > Start
  • scan certificate from multiple persons
  • select one person as the main user
  • delete all certificates from the selected user
  • restart app
  • open random certificate
  • check if the error report contains sensitive data eg.
    2021-10-07T14:33:31.472Z D/PersonCertificatesProvider: vaccPersons=[], tests=[], recos=[], cwaUser=CertificatePersonIdentifier(dateOfBirthFormatted=1982-02-11, lastNameStandardized=LIME, firstNameStandardized=MOTHER<MANDY)

Jira Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-9923

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Oct 11, 2021
@jurajkusnier jurajkusnier added this to the 2.11.0 milestone Oct 11, 2021
@jurajkusnier jurajkusnier requested a review from a team October 11, 2021 14:33
@BMItr BMItr self-assigned this Oct 11, 2021
@chiljamgossow chiljamgossow self-assigned this Oct 12, 2021
@jurajkusnier jurajkusnier changed the base branch from release/2.11.x to release/2.12.x October 12, 2021 09:02
@jurajkusnier jurajkusnier modified the milestones: 2.11.0, 2.12.0 Oct 12, 2021
chiljamgossow
chiljamgossow approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and logs are looking good

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.3% 96.3% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 5981a11 into release/2.12.x Oct 12, 2021
@mtwalli mtwalli deleted the fix/9923-cwa_user_censoring branch October 12, 2021 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chiljamgossow chiljamgossow chiljamgossow approved these changes

@BMItr BMItr BMItr approved these changes

Assignees

@BMItr BMItr

@chiljamgossow chiljamgossow

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jurajkusnier @BMItr @chiljamgossow @mtwalli @Corona-Warn-App-Technical-User