Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Statistics for boosters (EXPOSUREAPP-10765) #4680

Merged
merged 15 commits into from
Jan 17, 2022

Conversation

SamuraiKek
Copy link
Contributor

Added a new statistics card that shows the number of people with boosters.

To test it, switch to MOCK_CLOUD and the card should be second to last. Don't mind the values, they're inflated from the mock server.

Also, make sure it works in night mode and that all the people on the cards are now wearing a mask in both light/dark mode.

@SamuraiKek SamuraiKek added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Jan 11, 2022
@SamuraiKek SamuraiKek added this to the 2.17.0 milestone Jan 11, 2022
@SamuraiKek SamuraiKek requested review from a team January 11, 2022 12:39
@AlexanderAlferov AlexanderAlferov self-assigned this Jan 11, 2022
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think new text is missing in the Info Screen ℹ️ Kindly check the Figma 😄

@SamuraiKek
Copy link
Contributor Author

I think new text is missing in the Info Screen ℹ️ Kindly check the Figma 😄

Thanks, I always forget about it 😄

Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

CV113
CV113 previously approved these changes Jan 12, 2022
Copy link
Contributor

@CV113 CV113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@jurajkusnier jurajkusnier self-assigned this Jan 12, 2022
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double-check that Android texts are updated? There is a mismatch between iOS and Android design
out

@SamuraiKek SamuraiKek dismissed stale reviews from CV113 and AlexanderAlferov via 13830ae January 13, 2022 09:59
@SamuraiKek
Copy link
Contributor Author

Could you double-check that Android texts are updated? There is a mismatch between iOS and Android design

Turns out the iOS one is correct. I will update it.

Copy link
Contributor

@CV113 CV113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.0% 8.0% Coverage
12.9% 12.9% Duplication

@mtwalli mtwalli merged commit e971b16 into release/2.17.x Jan 17, 2022
@mtwalli mtwalli deleted the feature/10765-statistics-for-boosters branch January 17, 2022 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants