Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Onboarding Share Data - improve accessibility (EXPOSUREAPP-7540) #4688

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Onboarding Share Data - improve accessibility (EXPOSUREAPP-7540) #4688

merged 4 commits into from
Jan 18, 2022

Conversation

SamuraiKek
Copy link
Contributor

Ticket

How to test:

  • Activate TalkBack and go through the onboarding process.
  • When you reach the share data screen, listen for the announcement. The federal state/age group/district fields are read out, and their selected values can also be hear. TalkBack also let's you know that these fields are clickable by double tap.
  • Scroll down to the bottom of the page (use two fingers to scroll with talkback) and select the "Detailed Information..." field. This now also is announced as a clickable field by double tapping.

@SamuraiKek SamuraiKek added bug Something isn't working maintainers Tag pull requests created by maintainers accessibility Accessibility issues labels Jan 14, 2022
@SamuraiKek SamuraiKek added this to the 2.17.0 milestone Jan 14, 2022
@SamuraiKek SamuraiKek requested a review from a team January 14, 2022 16:14
@SamuraiKek SamuraiKek changed the title Onboarding share data improve accessibility (EXPOSUREAPP-7540) Onboarding Share Data - improve accessibility (EXPOSUREAPP-7540) Jan 14, 2022
jurajkusnier
jurajkusnier approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurajkusnier jurajkusnier self-assigned this Jan 18, 2022
@AlexanderAlferov AlexanderAlferov self-assigned this Jan 18, 2022
AlexanderAlferov
AlexanderAlferov approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SamuraiKek SamuraiKek merged commit 616dae6 into release/2.17.x Jan 18, 2022
@SamuraiKek SamuraiKek deleted the fix/7540-onboarding-share-data-accessibility branch January 18, 2022 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

@jurajkusnier jurajkusnier jurajkusnier approved these changes

Assignees

@jurajkusnier jurajkusnier

@AlexanderAlferov AlexanderAlferov

Labels
accessibility Accessibility issues bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuraiKek @jurajkusnier @AlexanderAlferov