Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Family Test skeleton P2 (EXPOSUREAPP-12323) #4948

Merged
merged 14 commits into from
Mar 18, 2022
Merged

Family Test skeleton P2 (EXPOSUREAPP-12323) #4948

merged 14 commits into from
Mar 18, 2022

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 17, 2022 •
edited
Loading

  • Common DI modules of family tests
  • FamilyTestRepository interface
  • Request certificate binding
  • Show Home tile / refreshing

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Mar 17, 2022
@mtwalli mtwalli added this to the 2.21.0 milestone Mar 17, 2022
@mtwalli mtwalli marked this pull request as ready for review March 18, 2022 03:07
@mtwalli mtwalli requested a review from a team March 18, 2022 03:07
SamuraiKek
SamuraiKek reviewed Mar 18, 2022
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Will approve once tests are passing.

@SamuraiKek SamuraiKek self-assigned this Mar 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

36.1% 36.1% Coverage
0.0% 0.0% Duplication

@BMItr BMItr self-assigned this Mar 18, 2022
BMItr
BMItr approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nothing to complain.
lgtm!

@mtwalli mtwalli merged commit c050153 into release/2.21.x Mar 18, 2022
@mtwalli mtwalli deleted the feature/12323-skeleton branch March 18, 2022 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BMItr BMItr BMItr approved these changes

@SamuraiKek SamuraiKek SamuraiKek approved these changes

Assignees

@SamuraiKek SamuraiKek

@BMItr BMItr

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mtwalli @SamuraiKek @BMItr