Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

replace JodaTime in analytics (EXPOSUREAPP-13114) #5199

Merged
merged 19 commits into from
May 25, 2022

Conversation

jurajkusnier
Copy link
Contributor

Get rid of JodaTime step by step, this time in the bug-reporting

Jira Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-13114

@jurajkusnier jurajkusnier added the maintainers Tag pull requests created by maintainers label May 18, 2022
@jurajkusnier jurajkusnier added this to the 2.23.x milestone May 18, 2022
@jurajkusnier jurajkusnier requested a review from a team May 18, 2022 11:51
@mtwalli mtwalli self-assigned this May 19, 2022
mtwalli
mtwalli previously approved these changes May 23, 2022
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiljamgossow chiljamgossow self-assigned this May 23, 2022
@jurajkusnier jurajkusnier changed the base branch from release/2.23.x to release/2.24.x May 24, 2022 14:50
@jurajkusnier jurajkusnier removed this from the 2.23.x milestone May 24, 2022
@jurajkusnier jurajkusnier added this to the 2.24.x milestone May 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

58.1% 58.1% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mtwalli mtwalli merged commit 37773ce into release/2.24.x May 25, 2022
@mtwalli mtwalli deleted the feature/13114-replace_joda_time_analytics branch May 25, 2022 08:56
chiljamgossow pushed a commit that referenced this pull request Jun 7, 2022
* replace JodaTime in analytics

* detekt

* remove unused code

* add year comparison

* return timezones

* ktlint

* use ChronoUnit to calculate days

Co-authored-by: BMItr <Berndus@gmx.de>
Co-authored-by: Marc Auberer <marc.auberer@chillibits.com>
Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants