This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
replace JodaTime in analytics (EXPOSUREAPP-13114) #5199
Merged
mtwalli
merged 19 commits into
release/2.24.x
from
feature/13114-replace_joda_time_analytics
May 25, 2022
Merged
replace JodaTime in analytics (EXPOSUREAPP-13114) #5199
mtwalli
merged 19 commits into
release/2.24.x
from
feature/13114-replace_joda_time_analytics
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
reviewed
May 19, 2022
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/datadonation/survey/Surveys.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/datadonation/survey/Surveys.kt
Outdated
Show resolved
Hide resolved
mtwalli
previously approved these changes
May 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...na-Warn-App/src/main/java/de/rki/coronawarnapp/datadonation/analytics/common/Calculations.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/datadonation/survey/Surveys.kt
Outdated
Show resolved
Hide resolved
.../coronawarnapp/datadonation/analytics/modules/testresult/AnalyticsTestResultCollectorTest.kt
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
mtwalli
approved these changes
May 25, 2022
9 tasks
chiljamgossow
pushed a commit
that referenced
this pull request
Jun 7, 2022
* replace JodaTime in analytics * detekt * remove unused code * add year comparison * return timezones * ktlint * use ChronoUnit to calculate days Co-authored-by: BMItr <Berndus@gmx.de> Co-authored-by: Marc Auberer <marc.auberer@chillibits.com> Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of JodaTime step by step, this time in the bug-reporting
Jira Ticket
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-13114