This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warn-app/cwa-app-android into feature/13085-GH-actions
* Remove TODO (Tested) * Remove * Use region * Remove forever TODOs * use region instead * Never used => remove * Revert * Lint
* Pay technical dept of AppConfig * Lint
* Code smells * Blame server all the time * Lint * Add 7 * Use native `combine` * lint * Pay 💰 flows tech debt 💸
# Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/appconfig/ui/AppConfigTestFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/internal/AppConfigSource.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up!
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/playbook/OrganizerPlaybook.kt
Show resolved
Hide resolved
schauersbergern
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The technical debt subtasks could have their own pull requests. Besides of that it looks fine
chiljamgossow
approved these changes
Jun 1, 2022
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Create android.yml * No specific distribution * Update android.yml * Cancel on progress * Update android.yml * on `push` only * Reusable actions * Run jobs * Fix * Reports * run 🏃♂️ `always` * try matrix * Fix syntax * inline options * Disable * Disable right class * Remove `-i` * Shorten * Options * Gradle `properties` * Update android.yml * Sort * Update ci-gradle.properties * Create build_and_test.yml * Create ReleaseCandidate.yml * Delete android.yml * Update build_and_test.yml * Sonar * Update build_and_test.yml * Revert "Update build_and_test.yml" This reverts commit 79bc433. * Run sonar * `Push` only * Remove `build` task * Sonar properties * Remove env key * Refer to env var * gradle ci properties * `--info` * remove duplicate * key * Tech dept P2 (EXPOSUREAPP-13177) (#5225) * Remove TODO (Tested) * Remove * Use region * Remove forever TODOs * use region instead * Never used => remove * Revert * Lint * Pay technical dept of AppConfig (EXPOSUREAPP-13168) (#5224) * Pay technical dept of AppConfig * Lint * Tech dept P3 (#5232) * Code smells * Blame server all the time * Lint * Add 7 * Use native `combine` * lint * Pay 💰 flows tech debt 💸 * Enable test Co-authored-by: Katharina Seiz <Katharina.Seiz@sap.com> Co-authored-by: Marc Auberer <marc.auberer@chillibits.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket