Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

GH actions (EXPOSUREAPP-13085) #5216

Merged
merged 59 commits into from
Jun 1, 2022
Merged

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented May 23, 2022

@mtwalli mtwalli added the enhancement Improvement of an existing feature label May 23, 2022
@mtwalli mtwalli marked this pull request as ready for review May 24, 2022 10:00
@mtwalli mtwalli requested a review from a team May 24, 2022 10:00
@mtwalli mtwalli changed the base branch from release/2.23.x to release/2.24.x May 24, 2022 14:49
@mtwalli mtwalli modified the milestones: 2.23.x, 2.24.x May 24, 2022
mtwalli added 4 commits May 24, 2022 16:54
* Remove TODO (Tested)

* Remove

* Use region

* Remove forever TODOs

* use region instead

* Never used => remove

* Revert

* Lint
* Pay technical dept of AppConfig

* Lint
@chiljamgossow chiljamgossow self-assigned this May 26, 2022
@schauersbergern schauersbergern self-assigned this Jun 1, 2022
mtwalli added 4 commits June 1, 2022 10:50
# Conflicts:
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/appconfig/ui/AppConfigTestFragment.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/internal/AppConfigSource.kt
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

Copy link
Contributor

@schauersbergern schauersbergern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The technical debt subtasks could have their own pull requests. Besides of that it looks fine

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.9% 42.9% Coverage
0.6% 0.6% Duplication

@mtwalli mtwalli merged commit ddf0b58 into release/2.24.x Jun 1, 2022
@mtwalli mtwalli deleted the feature/13085-GH-actions branch June 1, 2022 21:59
chiljamgossow pushed a commit that referenced this pull request Jun 7, 2022
* Create android.yml

* No specific distribution

* Update android.yml

* Cancel on progress

* Update android.yml

* on `push` only

* Reusable actions

* Run jobs

* Fix

* Reports

* run 🏃‍♂️ `always`

* try matrix

* Fix syntax

* inline options

* Disable

* Disable right class

* Remove `-i`

* Shorten

* Options

* Gradle `properties`

* Update android.yml

* Sort

* Update ci-gradle.properties

* Create build_and_test.yml

* Create ReleaseCandidate.yml

* Delete android.yml

* Update build_and_test.yml

* Sonar

* Update build_and_test.yml

* Revert "Update build_and_test.yml"

This reverts commit 79bc433.

* Run sonar

* `Push` only

* Remove `build` task

* Sonar properties

* Remove env key

* Refer to env var

* gradle ci properties

* `--info`

* remove duplicate

* key

* Tech dept P2 (EXPOSUREAPP-13177) (#5225)

* Remove TODO (Tested)

* Remove

* Use region

* Remove forever TODOs

* use region instead

* Never used => remove

* Revert

* Lint

* Pay technical dept of AppConfig (EXPOSUREAPP-13168) (#5224)

* Pay technical dept of AppConfig

* Lint

* Tech dept P3 (#5232)

* Code smells

* Blame server all the time

* Lint

* Add 7

* Use native `combine`

* lint

* Pay 💰 flows tech debt 💸

* Enable test

Co-authored-by: Katharina Seiz <Katharina.Seiz@sap.com>
Co-authored-by: Marc Auberer <marc.auberer@chillibits.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants