This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Use DataStore Approach - Part #1 (EXPOSUREAPP-13157) #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMItr
added
maintainers
mtwalli
reviewed
May 23, 2022
...arn-App/src/main/java/de/rki/coronawarnapp/bugreporting/debuglog/upload/history/LogUpload.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
May 24, 2022
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/preferences/FlowPreference.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
May 24, 2022
...a-Warn-App/src/main/java/de/rki/coronawarnapp/util/preferences/SharedPreferenceExtensions.kt
Outdated
Show resolved
Hide resolved
mtwalli
previously approved these changes
May 24, 2022
jurajkusnier
previously approved these changes
May 24, 2022
mtwalli
dismissed stale reviews from jurajkusnier and themself
The base branch was changed.
mtwalli
approved these changes
May 24, 2022
|
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Added some DataStoreExtensions, DataStoreExtensionsTest * Set FlowPreference deprecated * Added BaseJsonSerializer * Throw CorruptionException * BugReportingSettings -> UploadHistoryStorage * Deprecated * Added java time module for jackson * Restore with Gson * Added FakeTypedDataStore * Made UploadHistoryStorage resettable * Adjusted tests * Added UploadHistoryStorageTest * Removed BugReportingSettings * Better logging * Added UploadHistorySerializerTest * Added UploadHistoryStorageModuleTest * better Code * clean * trigger CI * clean * Comments * clean * removed deprecated annotations Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposureapp-13157
This PR refactores the usage of SharedPreferences and removes FlowPrefs etc.
Part #1.
Info: Do not merge yet.