This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix tests for screenshots (EXPOSUREAPP-11295) #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauersbergern
added
bug
schauersbergern
changed the title
mtwalli
previously approved these changes
May 30, 2022
|
LGTM so far, but have a look at the latest comments in the ticket? Looks like some screen is not scrolled all the way down. Will approve once that's clarified. @schauersbergern |
BMItr
previously approved these changes
May 30, 2022
schauersbergern
added
do not merge
and removed
bug
SamuraiKek
previously approved these changes
May 30, 2022
mtwalli
reviewed
May 30, 2022
schauersbergern
added
maintainers
mtwalli
approved these changes
Jun 1, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
chiljamgossow
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Add firebase_screenshots option * Fix name collision * Fix tests * Fix lint * Remove screenshots * fix scroll position, add screenshots * fix scroll position, add screenshots * remove interceptor * fine tune scrollposition * fine tune scrollposition * remove screenshots workflow Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests. This PR can be reviewed and merged