Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Unify flag SVG paths (EXPOSUREAPP-13310) #5267

Merged

Conversation

schauersbergern
Copy link
Contributor

@schauersbergern schauersbergern commented Jun 8, 2022

unify flag svg paths
Ticket

mtwalli and others added 30 commits June 1, 2022 14:12
…62-certs-preview-screen

# Conflicts:
#	Corona-Warn-App/src/main/assets/template/de_rc_v4.1.svg
#	Corona-Warn-App/src/main/assets/template/de_tc_v4.1.svg
#	Corona-Warn-App/src/main/assets/template/de_vc_v4.1.svg
#	Corona-Warn-App/src/main/assets/template/rc_v4.1.svg
#	Corona-Warn-App/src/main/assets/template/vc_v4.1.svg
#	Corona-Warn-App/src/main/res/navigation/covid_certificates_graph.xml
#	Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml
@schauersbergern schauersbergern requested a review from a team June 8, 2022 09:39
@schauersbergern schauersbergern added the maintainers Tag pull requests created by maintainers label Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Unit Test Results - Device Release

   555 files  ±0     555 suites  ±0   6m 15s ⏱️ +18s
2 734 tests ±0  2 734 ✔️ ±0  0 💤 ±0  0 ±0 
2 783 runs  ±0  2 783 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 2d2ecf8. ± Comparison against base commit 945c4d9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Unit Test Results - Device For Tester Release

   558 files  ±0     558 suites  ±0   6m 23s ⏱️ +35s
2 740 tests ±0  2 740 ✔️ ±0  0 💤 ±0  0 ±0 
2 789 runs  ±0  2 789 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 2d2ecf8. ± Comparison against base commit 945c4d9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Firebase Test Results

    2 files  ±0      2 suites  ±0   4m 42s ⏱️ +36s
129 tests ±0  129 ✔️ ±0  0 💤 ±0  0 ±0 
258 runs  ±0  258 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 2d2ecf8. ± Comparison against base commit 945c4d9.

♻️ This comment has been updated with latest results.

Base automatically changed from feature/13262-certs-preview-screen to feature/13018-export-all-certs June 8, 2022 10:21
@mtwalli mtwalli requested a review from a team June 8, 2022 10:21
@mtwalli mtwalli self-assigned this Jun 8, 2022
@mtwalli mtwalli changed the title unify flag svg paths Unify flag SGV paths (DEV) Jun 8, 2022
@mtwalli mtwalli changed the title Unify flag SGV paths (DEV) Unify flag SVG paths (DEV) Jun 8, 2022
@mtwalli mtwalli changed the title Unify flag SVG paths (DEV) Unify flag SVG paths (EXPOSUREAPP-13310) Jun 8, 2022
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely

@chiljamgossow chiljamgossow self-assigned this Jun 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

11.7% 11.7% Coverage
0.1% 0.1% Duplication

@mtwalli mtwalli merged commit 1cb4410 into feature/13018-export-all-certs Jun 8, 2022
@mtwalli mtwalli deleted the feature/13310-unify-flag-svgpaths branch June 8, 2022 11:24
mtwalli added a commit that referenced this pull request Jun 8, 2022
…5250)

* Add ToDo

* Implement new Toolbar in person overview (EXPOSUREAPP-13260) (#5253)

* Toolbar icons

* Connect icons

* Tooltip

* Update Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml

Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

Co-authored-by: Alex Paulescu <alex.paulescu@gmail.com>
Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

* Adapt release not strings. (#5262)

* All certificates PDF export info screen (EXPOSUREAPP-13261) (#5258)

* Add pdf export info screen.

* Update Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml

Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

* Use new texts.

Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

* DCC export filter and sorting (EXPOSUREAPP-13311) (#5266)

* filter

* filter

* test

* Certs preview screen (EXPOSUREAPP-13262) (#5260)

* Toolbar icons

* Connect icons

* Tooltip

* Web Approach

* Inject data

* Lint

* Lint

* Common fields

* `use`

* rename

* Zoom

* unique template classes

* Adjust style

* Page

* Toolbar

* Remove `EU` flag

* toolbar actions

* Update CertificateTemplate.kt

* Print

* px

* Progress

* Size

* Enhancing

* Fix tests

* Avoid multi inflate

* Name

* `-`

* catch error

* Share PDF

* Update DccExportAllOverviewFragment.kt

* move to vm

* Refactoring

* Docs

* Log

* Progress / error messages

* Catch errors

* lint

* Alignment

* Update Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml

Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

* Update Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml

Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

* Format

* Main dispatcher

* create pdf

* Delete file

* Formatting

* Clean up

* lint

* Cleaning

* bind filteriing

* lint

* Avoid crash

Co-authored-by: Nikolaus Schauersberger <nikolaus.schauersberger@gmail.com>
Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

* Unify flag SVG paths (EXPOSUREAPP-13310) (#5267)

* Toolbar icons

* Connect icons

* Tooltip

* Web Approach

* Inject data

* Lint

* Lint

* Common fields

* `use`

* rename

* Zoom

* unique template classes

* Adjust style

* Page

* Toolbar

* Remove `EU` flag

* toolbar actions

* Update CertificateTemplate.kt

* Print

* px

* Progress

* Size

* Enhancing

* Fix tests

* Avoid multi inflate

* Name

* `-`

* catch error

* Share PDF

* Update DccExportAllOverviewFragment.kt

* move to vm

* Refactoring

* Docs

* Log

* Progress / error messages

* Catch errors

* lint

* Alignment

* Update Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml

Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

* Update Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml

Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

* Format

* Main dispatcher

* create pdf

* Delete file

* Formatting

* Clean up

* lint

* Cleaning

* bind filteriing

* lint

* Avoid crash

* unify flag svg paths

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>

Co-authored-by: Alex Paulescu <alex.paulescu@gmail.com>
Co-authored-by: KathrinLuecke <91470863+KathrinLuecke@users.noreply.github.com>
Co-authored-by: Chilja Gossow <49635654+chiljamgossow@users.noreply.github.com>
Co-authored-by: Nikolaus Schauersberger <nikolaus.schauersberger@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants