This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
[ Java Time ] Everywhere (EXPOSUREAPP-2846) #5605
Merged
mtwalli
merged 34 commits into
release/2.28.x
from
feature/14012-risk-exposure-java-time
Oct 5, 2022
Merged
[ Java Time ] Everywhere (EXPOSUREAPP-2846) #5605
mtwalli
merged 34 commits into
release/2.28.x
from
feature/14012-risk-exposure-java-time
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Joda bye 👋 * Clean up * Update DefaultExposureDetectionTracker.kt * Fix merge issue * Update tests * Update TimeIntervalDeriverTest.kt * Update ProfileDataCreateFragmentViewModelTest.kt * Update TracingData.kt * Update ProfileQrCodeFragmentTest.kt * Update ProfileQrCodeFragmentTest.kt * Update VCard.kt * Update CommonConvertersTest.kt * Update TimeAndDateExtensionsTest.kt * Format time interval * Java 11 time support * Relative time interval * Format duration
...p/src/androidTest/java/de/rki/coronawarnapp/contactdiary/storage/ContactDiaryDatabaseTest.kt
Show resolved
Hide resolved
.../de/rki/coronawarnapp/contactdiary/storage/internal/converters/ContactDiaryRoomConverters.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/diagnosiskeys/server/DiagnosisKeyServer.kt
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/statistics/StatisticsModule.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/TimeAndDateExtensions.kt
Outdated
Show resolved
Hide resolved
SamuraiKek
previously approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I've scanned tests, certificates, created entries in the journal and created events in which I've checked in. I didn't find differences between 2.27 and this branch.
mtwalli
changed the title
[ Java Time ] Everywhere
[ Java Time ] Everywhere (EXPOSUREAPP-2846)
Oct 4, 2022
schauersbergern
previously approved these changes
Oct 5, 2022
# Conflicts: # Corona-Warn-App/build.gradle # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/tracing/ui/TracingExplanationDialog.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentEvents.kt
mtwalli
dismissed stale reviews from schauersbergern and SamuraiKek
via
October 5, 2022 07:43
2bb7d46
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure upgrading from 2.27 to this branch , is working fine and time formats are the same
Ticket
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-2846