Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Clean up / Upgrade outdated libs(EXPOSUREAPP-14042) #5609

Merged
merged 27 commits into from
Oct 5, 2022
Merged

Clean up / Upgrade outdated libs(EXPOSUREAPP-14042) #5609

merged 27 commits into from
Oct 5, 2022

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Oct 4, 2022 •
edited
Loading

mtwalli added 14 commits October 2, 2022 12:34
@mtwalli
Clean up
57c61f0
@mtwalli
jni
11cfd11
@mtwalli
Upgrade
284d252
@mtwalli
Update proguard-rules.pro
1626ec0
@mtwalli
Update build.gradle
958487a
@mtwalli
namespace
f7d1d57
@mtwalli
Implied Unit
6a65993
@mtwalli
Security
718ad93
@mtwalli
extra ending
dc372ce
@mtwalli
no Nullable annotation in Kotlin
89ed391
@mtwalli
autoSizeTextType for older versions
67ff65e
@mtwalli
not used
c380ad2
@mtwalli
split <data>
7647dfe 
intent-filter> <data> tags should only declare a single unique attribute (i.e. scheme OR host, but not both). This better matches the runtime behavior of intent filters, as they combine all of the declared data attributes into a single matcher which is allowed to handle any combination across attribute types.

For example, the following two <intent-filter> declarations are the same:
<intent-filter>
    <data android:scheme="http" android:host="example.com" />
    <data android:scheme="https" android:host="example.org" />
</intent-filter>
<intent-filter>
    <data android:scheme="http"/>
    <data android:scheme="https"/>
    <data android:host="example.com" />
    <data android:host="example.org" />
</intent-filter>

They both handle all of the following:
* http://example.com
* https://example.com
* http://example.org
* https://example.org
@mtwalli
Update top_app_bar_shape.xml
57937a7
@mtwalli mtwalli added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers labels Oct 4, 2022
@mtwalli mtwalli added this to the 2.28.x milestone Oct 4, 2022
mtwalli
mtwalli commented Oct 4, 2022
View reviewed changes
@mtwalli mtwalli changed the title Clean up (DEV) Clean up / Upgrade outdated libs(DEV) Oct 4, 2022
@mtwalli mtwalli marked this pull request as ready for review October 4, 2022 13:07
@mtwalli mtwalli requested a review from a team October 4, 2022 13:07
@mtwalli mtwalli changed the title Clean up / Upgrade outdated libs(DEV) Clean up / Upgrade outdated libs(EXPOSUREAPP-14042) Oct 4, 2022
@SamuraiKek SamuraiKek self-assigned this Oct 5, 2022
SamuraiKek
SamuraiKek approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, nice to have some warnings removed 🚀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

9.5% 9.5% Coverage
4.9% 4.9% Duplication

@mtwalli mtwalli merged commit c9907ca into release/2.28.x Oct 5, 2022
@mtwalli mtwalli deleted the dev/clean-up branch October 5, 2022 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuraiKek SamuraiKek SamuraiKek approved these changes

Assignees

@SamuraiKek SamuraiKek

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.28.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mtwalli @SamuraiKek