Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Update mixed up strings in statistics info screen (EXPOSUREAPP-14351) #5730

Merged
merged 5 commits into from
Nov 24, 2022

Conversation

SamuraiKek
Copy link
Contributor

@SamuraiKek SamuraiKek commented Nov 23, 2022

@SamuraiKek SamuraiKek added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Nov 23, 2022
@SamuraiKek SamuraiKek added this to the 3.0.x milestone Nov 23, 2022
@SamuraiKek SamuraiKek requested a review from a team November 23, 2022 09:22
@@ -1498,7 +1498,7 @@ Sollten Sie den Test in der App gelöscht haben, können Sie ihn aus dem Papierk
<!-- XHED: Explanation screen confirmed new infections title -->
<string name="statistics_explanation_confirmed_new_infection_title">"Bestätigte Neuinfektionen"</string>
<!-- XTXT: Explanation screen confirmed new infections text -->
<string name="statistics_explanation_confirmed_new_infection_text" formatted="false">"Anzahl der an das RKI übermittelten Corona-positiv getesteten Personen. Anzahlen unter einem Schwellenwert von 1% des 7-Tage-Mittelwerts werden nicht angezeigt; siehe auch Erläuterung unter Legende > Zeitraum."</string>
<string name="statistics_explanation_confirmed_new_infection_text">"Gesamtzahl der bestätigten Neuinfektionen der letzten 7 Tage (nach Meldedatum) pro 100.000 Einwohner."</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this will now display correctly on the screen because the strings have been exchanged, but the string names do not fit the content.
Here the string name is "statistics_explanation_new_infection_text", and the text is about new infections of the last 7days per 100.000 inhabitants. So this text is related to the 7day incidence and should rather be inserted for "statistics_explanation_seven_day_incidence_text". And it must display under the title "7-Tage Inzidenz" (statistics_explanation_seven_day_incidence_title").
And for "statistics_explanation_new_infection_text", the text should be "Anzahl der an das RKI übermittelten Corona-positiv getesteten Personen. Anzahlen unter einem Schwellenwert..." and needs to be displayed under the title: "Bestätigte Neuinfektionen" (statistics_explanation_confirmed_new_infection_title)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have reverted the changes to the actual strings and just switched their use in the UI.

Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SamuraiKek SamuraiKek merged commit c025a3c into release/3.0.x Nov 24, 2022
@SamuraiKek SamuraiKek deleted the fix/14351-mixed-up-text-statistics-info branch November 24, 2022 06:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants