This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Removed manual request of portrait screen orientation in Application class (no related issue) #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironjan
force-pushed
the
remove-manual-request-of-screen-orientation-in-application-class
branch
2 times, most recently
from
db31022 to
5195440
Compare
…class * Screen orientation is already set to portrait in AndroidManifest.xml
ironjan
force-pushed
the
remove-manual-request-of-screen-orientation-in-application-class
branch
from
5195440 to
7340b1d
Compare
|
We are switching our branching approach, |
|
@d4rken it would be appreciated if someone would take a look at the pull
request. The fitting release branch would be "whatever comes after the
review". My work here is done ;)
Matthias Urhahn <notifications@github.com> schrieb am Mo., 21. Sept. 2020,
10:25:
… We are switching our branching approach, dev is going to be deleted, to
do this there can't be any open PRs against it. I'm switching this PR to
master, before merging this PR switch it to a fitting target release
branch, i.e. release/1.X.Y
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#779 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM6YFDGTU52TEXOH6ZAXHDSG4EXJANCNFSM4OKP5XLA>
.
|
d4rken
added
community
d4rken
changed the title
|
Will close this. See Follow-Up PR #1272 |
|
Thanks.
Mert Safter <notifications@github.com> schrieb am Do., 1. Okt. 2020, 14:04:
… Closed #779 <#779>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#779 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM6YFEYQUQ3LUHB2RBH4E3SIRV6PANCNFSM4OKP5XLA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the app only supports portrait mode. Since #738, the screen orientation is now requested via the
AndroidManifext.xml(See l. 41, l. 51, l. 56).The only exception is
CaptureActivitywhich usesfullSensoras seen in l. 61.@SebastianWolf-SAP - could you clarify on how the
CaptureActivityshould behave*? Neither before my change, nor after the change, the Capture Screen rotates to landscape (nor any other orientation). However, since the orientation is not locked via the application class's onActivty anymore, theCaptureActivitynow should orient itself but it stays in portrait mode.*Latest change in L61 was made by you, so I assume you are the best person to ask.