This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix/3711 refactor cached app config #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add guard to prevent config processing if it didn't change.
# Conflicts: # src/xcode/ENA/ENA.xcodeproj/project.pbxproj
whiskey
approved these changes
Nov 13, 2020
| let bundle = Bundle(for: CachingHTTPClientMock.self) | ||
| // there is a test for this (`testStaticAppConfiguration`), let's keep it short. | ||
| guard | ||
| let fixtureUrl = bundle.url(forResource: "de-config-int-2020-09-25", withExtension: nil), |
There was a problem hiding this comment.
Just FYI, the app configuration format will change in the next two sprints which will likely break the deserialization. However, with the default app configuration on the horizon we might have this covered!
Unless we have a need for a bespoke config, we could use the static default configuration, right?
There was a problem hiding this comment.
Good point. Made use if CachingHTTPClientMock.staticAppConfig
| self.packageStore?.revokationList = revokationList // for future package-operations | ||
| // validate currently stored key packages | ||
| do { | ||
| try self.packageStore?.validateCachedKeyPackages(revokationList: revokationList) | ||
| } catch { | ||
| Log.error("Error while removing invalidated key packages.", log: .localData, error: error) | ||
| Log.error("[App Config] Error while removing invalidated key packages.", log: .localData, error: error) |
There was a problem hiding this comment.
We could create custom OSLog keys for .cache and .appConfig!? This would allow nicer filtering for the different components.
There was a problem hiding this comment.
Added .appConfig and used it.
marcussc
approved these changes
Nov 13, 2020
This was referenced Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents the race condition which is leading to trigger risk detection more then the timeframe (24h) allows.
The meta data and the cached app config are persisted at once, preventing data collisions when the cache called multiple times.
Link to Jira
links follows. Cant access jira atm.