-
Notifications
You must be signed in to change notification settings - Fork 387
Fix docker compose wait-for-it.sh script #339
Comments
@AlexanderBarbie would you know how to fix this perhaps? |
Well, that's why you don't develop software on Windows systems. 😄 |
@pithumke can you please tell me which Docker version you are using and did you add the wait-for-it folder under Resources > File Sharing in the Docker settings? And did you get the error
This can be a problem with the line ending. Windows changes the line endings of downloaded files and then you can't start the bash script in a linux environment. I just checked out your commit #337 and had to change the line ending to unix line endings in my eclipse. Afterwards the error disappeared. |
@AlexanderBarbie Thanks for picking this up! My versions are:
I did not add the "wait-for-it" script to the Docker file sharing settings, as it is already being included as a volume mount:
The specific console output I got when running
Upon playing around with the error and including some |
* Revert "reduce version definitions in POMs (#265)" This reverts commit 478a586. * always checkout wait-for-it.sh with LF eol * re-enable entry point * enforce LF on all sh files * removed text attributes * test * test * test * force LF on for wait-for-it.sh on commit and checkout re-enable entry point enforce LF on all sh files removed text attributes test test test * removed blank line * added LF which seems required for git to update file EOLs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Steve <steve.amihai.ben.ezra@sap.com>
Current status
The execution of the existing wait-for-it.sh script was reverted in #338 since it was not executing properly in windows.
Error message from
docker-compose run create-bucket
is:No such file or directory
Expected Behavior
wait-for-it.sh should execute properly in linux, mac and windows environments
The text was updated successfully, but these errors were encountered: