-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct FAQ entry for green/low risk encounters #307
Comments
I have corrected my experiment after accounting for certain sanity check inside EN: https://github.com/corona-warn-app/cwa-backlog/issues/23#issuecomment-678644207, and it seems that all encounters, regardless of how CWA is configured, would be displayed in log and as "low-risk exposure" in CWA, so I think the FAQ entry is correct |
Even if the FAQ entry is correct, I think it should be made clearer that all Encounters are shown to the user.
But then there is written:
In German the same:
The word "discarded"(="verworfen") implicate that there are some Exposures who are discarded (=deleted, etc.). |
Hello everyone, thank you all for your feedback! Regarding the initial concern of @daimpi it seems that 10 minutes are indeed correct. Regarding the redactional change that @Ein-Tim suggested, I will now forward this to the responsible person who can do this change for us. I think it's a good improvement and will lead to less confusion. Best regards, Corona-Warn-App Open Source Team |
My main motivation for opening this issue was actually the first point, regarding the suggestion that "discarded encounters will be shown as green-/low-risk encounters". This was a contradiction to @thomasaugsten's comment here which stated that such encounters would not be shown in either CWA nor the ENF log in any form. But since @kbobrowski has tested this and found that actually no encounters will be hidden from the user, this contradiction no longer exists (even though it would be nice to actually get confirmation on this by the devs, just to be sure). I also agree with @Ein-Tim's statement above, that using the word "discarded" seems misleading and should be improved. When improving the FAQ entry I'd also suggest improving those statements in the risk-assessment documentation which the FAQ entry links to, to make it clear that no encounters will be hidden from the user. Regarding the 2nd point (the "less than 10 min" statement): after reading a bit more, it seems that listening windows are not necessarily 5 min apart, but rather that there also exist closer scan intervals of only 2.5 min apart. |
Looks good to me 👍 |
Oops, that link was supposed to be #319 ... my bad |
Looks good to me 👍 What do you think wrt the risk-assessment documentation which the FAQ entry links to? Should we make a separate issue in the documentation repo for this? 🙂 |
@tkowark could you maybe confirm with the CWA iOS devs/Apple whether @kbobrowski's findings (i.e. no encounter will be hidden in CWA & the ENF log) also apply to iOS, just to be save? 🙂 |
@tkowark |
This are the encounters which are filtered out by the ENF via the configuration. This encounters are not sent to the CWA and not count in the matchCount. |
Ok, and these are the Encounters under 10 Minutes and not nearer than 73 db, right? |
your comment is exclusively about iOS? B/c under Android obviously no encounters are filtered out. Every encounter is at least shown as "low risk/green". Could you please clarify? |
As far as we could confirm, on Android all the encounters are displayed at least as "low-risk encounter", even if it lasted 5 minutes with 100dB attenuation, this was also independently confirmed: https://covidapps.slack.com/archives/C0194ML0MLN/p1598517214083800 |
iOS and Android using the same configuration for the ENF If you see a different behavior of the Android ENF please a create ticket with detailed information we will check this with google. |
@thomasaugsten : Are you saying that the behavior seen under Android wrt those "very low risk" encounters is not the same as you observe under iOS? Were you able to test this? B/c according to Google spec In particular this last sentence:
it seems like |
@thomasaugsten I cannot verify what is the behavior on iOS, can only report here that on Android no encounters are "filtered out" inside ENF by configuration - meaning that all the encounters, however short or weak signal, would be included in "matchedKeyCount". You can see it in this comment: https://github.com/corona-warn-app/cwa-backlog/issues/23#issuecomment-679231707 , encounter had very weak signal (above 80), but still ENF counted it in "matchedKeyCount", although the risk value associated with this encounter is 0. I'm not sure if this is the issue as it seems to be intended behavior. |
Thanks for the hint we will double check this with google. |
Thanks 🙂 |
Yes of course we will check this with apple to ensure we have a consistent API here. |
We got an official statement from the Robert Koch Institute: German
English
Further text improvements are being introduced in the upcoming hotfix release 1.3.1. RC1 of 1.3.1 is already available: Since the decision from the RKI is final, I will close this issue now. Best regards, Corona-Warn-App Open Source Team |
Were you able to confirm that this behavior is consistent between Android and iOS (i.e. that all encounters are shown on both OS)? |
Where to find the issue
German and English FAQ entry on green risk encounters.
Describe the issue
The current entry states:> All exposures for a diagnosis key that lasted less than 10 minutes in total (regardless of how close the smartphones came during that time) or during which the smartphones were more than 8 meters (73 dB attenuation) apart on average (regardless of how long the exposure lasted) are discarded as harmless. This is why the Corona-Warn-App can display encounters, but the risk status stays the same.This suggests that encounters which are "discarded as harmless" are actually shown as green-/low-risk encounters, which is not correct.Also: This suggests that only encounters shorter than 10 minutes would be discarded (which I guess corresponds to discarding encounters which only appeared in one listening window), when in reality encounters that are shorter than 15 min (i.e. up to and including 10 min (gt_5_le_10_min: 0
) / two listening windows) are discarded.Suggested change
1. Change the text so that it is clear that such encounters will be hidden from the user and not shown as green-/low-risk encounters.2. Change the text regarding the time cutoff to state that encounters shorter than 15 min are discarded.
Edit:
The 2nd point actually also applies to the risk-assessment documentation which is linked there and states:> All encounters for a diagnosis key that lasted less than 10 minutes in total […] are discarded as negligible risk.This should also say "less than 15 minutes".Edit2:
Regarding the change to "less than 15 minutes": just make sure that I'm not talking nonsense here 😅After looking at the config file again and seeing the
eq_0_min
entry (which seems to be pretty nonsensical if this would actually correspond to zero listening windows) I'm not entirely sure how the time mapping works, so just check with the ppl who know the details on how exactly this mapping works before changing anything.Edit3:
As @kbobrowski already stated below: it turns out that the FAQ entry seems to be correct after all: https://github.com/corona-warn-app/cwa-backlog/issues/23#issuecomment-679231707I'd suggest putting this issue on hold until this has been clarified by the devs, just to be sure. If they confirm this, the issue can be closed. Although the question on how exactly the mapping/interaction between duration and exposure windows works would still be interesting 🙂.Edit4: After #343 has been merged, the FAQ now actually contains a bug: the new formulation suggests that not all encounters would be shown in the app which is contradicted by @kbobrowski's findings. I would suggest reverting #343 until this issue is sorted out to reduce the number of people receiving misinformation via the FAQ but in the meantime you can replace the enhancement label of this issue with the bug label again.
Internal Tracking ID: EXPOSUREAPP-2344
The text was updated successfully, but these errors were encountered: