Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The titel Sections is not in the center-position #3233

Closed
MohamedZaghdoudi opened this issue Nov 21, 2022 · 8 comments
Closed

The titel Sections is not in the center-position #3233

MohamedZaghdoudi opened this issue Nov 21, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@MohamedZaghdoudi
Copy link
Contributor

Where to find the issue:

https://www.coronawarn.app/en/faq/

Describe the issue:

the Position of Sections is not in the Center .

Suggestion :

switch in _reboot.scss the position from text-align from "$body-text-align " to "center"

@MikeMcC399
Copy link
Contributor

@MohamedZaghdoudi

  • Why is this closed? Normally you would close an issue after it has been resolved through merging a PR.

  • I commented on the issue Faq Sections in the center #3234 which you opened. Unfortunately it has some major side-effects.

  • I have also noticed that there is a lot of use of the <center> tag on many pages, however this tag, which was already deprecated in HTML4, is not supported in HTML5, so in fact this is a general issue on the website.

@MikeMcC399
Copy link
Contributor

@MohamedZaghdoudi
Copy link
Contributor Author

@MikeMcC399 okay i will see it now

@MikeMcC399
Copy link
Contributor

@MohamedZaghdoudi

Maybe you could also correct a typo in the subject?

"tittel" should be "title"

@MohamedZaghdoudi MohamedZaghdoudi changed the title The tittel Sections is not in the center-position The titel Sections is not in the center-position Nov 22, 2022
@MohamedZaghdoudi
Copy link
Contributor Author

@MikeMcC399 thank you for your feedback . It is done.

@MikeMcC399
Copy link
Contributor

@MohamedZaghdoudi

In English it is spelled "title" not "titel".

@brianebeling
Copy link
Member

Closing this issue as it became a bit misleading. Originally we wanted to recenter the content under "Sections". It looks a bit misaligned. We did not want to center the headline itself.

Please refer to: #3246

@brianebeling brianebeling closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2022
@MikeMcC399
Copy link
Contributor

@brianebeling

I agree that this was a confusing issue. Also the suggested resolution to edit _reboot.scss did not work and probably was not the right place to make a single layout change anyway.

_reboot.scss looks like it comes from
https://github.com/twbs/bootstrap/blob/main/scss/_reboot.scss as described in https://getbootstrap.com/docs/4.0/content/reboot/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants