-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAQ Sections is not centered #3246
Comments
I think e.g. "Check-in" & "iOS" are one purpose only slightly visible, to make it clear to the user that there is more to that then only the topics that are shown. I really like this, as it is quite a low-key way to tell the user: "Hey, there's more!". Centering the whole list makes sense. Btw, I think in your title "had" should be "has". |
The logic seems to be a bit strange. The list can have indexed and non-indexed titles. Only the indexed titles are shown in https://www.coronawarn.app/en/faq/. If there are 7 or more titles (whether they are shown or not) then the last title in the list is faded out. It would be more intuitive to view if the number of displayed titles is limited to the same number. So you would need to count the number of displayed titles instead of the number of all titles. |
Please note when making changes to this layout that it is dynamic, according to the browser width. |
Whoops, you are right. I slipped, thanks for letting me know!
For now I removed the visibility thing. I wasn't realizing its a feature and not a bug. For some reason it does look off to me. At the moment I can't pinpoint what it is though.. |
For the positioning I suggest you check out Bootstrap flex which is already in use on this page. |
Let me know if you want a PR for this. I tried out my suggestion from above ^^ and it seemed to work, including with various browser widths. |
@MikeMcC399 That'd be great. I can review it right now as well. I will let @MohamedZaghdoudi know that he can stop working on this! Thanks! |
|
@MikeMcC399 thank you very much for your work. It looks much better. |
|
Ah, yes, thank you. I clocked out yesterday and was in a hurry. Closing this now. 😄 |
Where to find the issue
https://www.coronawarn.app/en/faq/
Describe the issue
Centering:
Suggested change
Move the content (and title) to the right
The text was updated successfully, but these errors were encountered: