Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ Sections is not centered #3246

Closed
brianebeling opened this issue Nov 26, 2022 · 11 comments
Closed

FAQ Sections is not centered #3246

brianebeling opened this issue Nov 26, 2022 · 11 comments
Assignees
Labels
bug Something isn't working enhancement Improvement of an existing feature

Comments

@brianebeling
Copy link
Member

brianebeling commented Nov 26, 2022

Where to find the issue

https://www.coronawarn.app/en/faq/

Describe the issue

Centering:
image

Suggested change

Move the content (and title) to the right

@brianebeling brianebeling added bug Something isn't working enhancement Improvement of an existing feature labels Nov 26, 2022
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Nov 26, 2022

I think e.g. "Check-in" & "iOS" are one purpose only slightly visible, to make it clear to the user that there is more to that then only the topics that are shown. I really like this, as it is quite a low-key way to tell the user: "Hey, there's more!".

Centering the whole list makes sense.

Btw, I think in your title "had" should be "has".

@MikeMcC399
Copy link
Contributor

The logic seems to be a bit strange. The list can have indexed and non-indexed titles. Only the indexed titles are shown in https://www.coronawarn.app/en/faq/. If there are 7 or more titles (whether they are shown or not) then the last title in the list is faded out. It would be more intuitive to view if the number of displayed titles is limited to the same number. So you would need to count the number of displayed titles instead of the number of all titles.

@MikeMcC399
Copy link
Contributor

Please note when making changes to this layout that it is dynamic, according to the browser width.

@brianebeling brianebeling changed the title FAQ Sections is not centered and had visibility issues FAQ Sections is not centered Nov 26, 2022
@brianebeling
Copy link
Member Author

brianebeling commented Nov 26, 2022

I think e.g. "Check-in" & "iOS" are one purpose only slightly visible, to make it clear to the user that there is more to that then only the topics that are shown. I really like this, as it is quite a low-key way to tell the user: "Hey, there's more!".

Centering the whole list makes sense.

Btw, I think in your title "had" should be "has".

Whoops, you are right. I slipped, thanks for letting me know!

The logic seems to be a bit strange. The list can have indexed and non-indexed titles. Only the indexed titles are shown in coronawarn.app/en/faq. If there are 7 or more titles (whether they are shown or not) then the last title in the list is faded out. It would be more intuitive to view if the number of displayed titles is limited to the same number. So you would need to count the number of displayed titles instead of the number of all titles.

For now I removed the visibility thing. I wasn't realizing its a feature and not a bug. For some reason it does look off to me. At the moment I can't pinpoint what it is though..

@MikeMcC399
Copy link
Contributor

@brianebeling

For the positioning I suggest you check out Bootstrap flex which is already in use on this page. d-flex justify-content-center with text-center and text-left in the right places may be all that is needed.

@MikeMcC399
Copy link
Contributor

@brianebeling

Let me know if you want a PR for this. I tried out my suggestion from above ^^ and it seemed to work, including with various browser widths.

@brianebeling
Copy link
Member Author

@MikeMcC399 That'd be great. I can review it right now as well. I will let @MohamedZaghdoudi know that he can stop working on this! Thanks!

@MikeMcC399
Copy link
Contributor

@brianebeling

  • I have submitted Center the FAQ lists #3255 to center the FAQ section list. I also centered the title because it looked better that way. Screenshots are in the PR.

@MohamedZaghdoudi
Copy link
Contributor

MohamedZaghdoudi commented Nov 28, 2022

@MikeMcC399 thank you very much for your work. It looks much better.

@MikeMcC399
Copy link
Contributor

@brianebeling

@brianebeling
Copy link
Member Author

Ah, yes, thank you. I clocked out yesterday and was in a hurry. Closing this now. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants