-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center the FAQ lists #3255
Center the FAQ lists #3255
Conversation
Hey @MikeMcC399 Thanks for the change. Unfortunately I'm unable to review it today as I would really like to take a more in-depth look. Specifically I'd like to review the centered title and see if we can find some alternatives. But I also want to take the opinion of others into consideration if possible. |
Please take your time. There is no urgency from my side. If it is desired to have the "Sections" title on the left again that would be an easy change (just move As the screen gets narrower it is more noticeable how much white space is used. I haven't changed this. If you want to do further layout optimisation it might be an idea to create a separate non-fork branch instead of |
@brianebeling just tell me when its ready to review :) |
@MikeMcC399 This might be a bit of a wild idea, but what if we remove the Sections title? I don't think it adds any value. Just looking at the table already suggests these are the categories or sections available. |
I think it would be possible to spend quite a bit of time investigating and optimising these and related points. For the moment I would restrict this PR to the centering topic only. If you want me to put the "Sections" header back on the left again, let me know and I will update the PR. I would however not want to remove it as an isolated change to this page. |
Yes, I agree that there are quite some issues. Then also not a lot of urgency to change much. It'd certainly improve the usability and visual appearance of the site, if it was a bit refined and weight of elements reconsidered. The more I look at it, the more of an urge I get to work on this. 😆 Sadly the issue of the visual alignment still remains. If you measure the flexbox or inspect element, it is truly aligned. But it doesn't look aligned. That is because the rightmost column is shorter than the other columns, but they are equal width. As such creating a left-sided balance. I fixed it with a |
Please go ahead as you wish with this PR! |
This reverts commit 82fa231.
This PR resolves the enhancement request #3246 "FAQ Sections is not centered".
The lower section of https://www.coronawarn.app/en/faq/ is now centered so that it has a consistent look independently of the available browser width.
Old
Previously
New
Desktop wide
Desktop narrow
Mobile