Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress - check for broken links #1786

Merged
merged 6 commits into from
Oct 1, 2021
Merged

Cypress - check for broken links #1786

merged 6 commits into from
Oct 1, 2021

Conversation

dsarkar
Copy link
Member

@dsarkar dsarkar commented Oct 1, 2021

ToDo:

  • filter out email and tel
  • filter out duplicates, e.g. #top
  • add all pages

Usage on local built:

  • npx Cypress open
  • click on check_links.js
    image
  • execution
    image
  • see result, e.g.

image


Internal Tracking ID: EXPOSUREAPP-9734

@dsarkar dsarkar requested a review from a team October 1, 2021 09:17
@dsarkar dsarkar self-assigned this Oct 1, 2021
@dsarkar dsarkar added enhancement Improvement of an existing feature mirrored-to-jira labels Oct 1, 2021
@MikeMcC399
Copy link
Contributor

@dsarkar
This is a great addition to the cypress tests!

It looks like you are not testing the whole site though, just selected sections. /en/blog/ & /de/blog for instance is missing. What about the top level /en and /de? The original analysis PR broke some links at the top level, so it would be good to check there as well.

npm run test:open then selecting check_links.js runs the test as expected.

I tried also running npm run test where all available tests are chained.

The goal of course should be to get check_links.js and the website itself in a state where the tests all pass!

@mtb77 mtb77 self-requested a review October 1, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature mirrored-to-jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants