Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emergentalliance.org to check links exceptions #3185

Merged
merged 3 commits into from
Oct 30, 2022
Merged

Add emergentalliance.org to check links exceptions #3185

merged 3 commits into from
Oct 30, 2022

Conversation

MikeMcC399
Copy link
Contributor

This PR resolves the issue #3184 "Cypress times out checking https://emergentalliance.org/" by adding https://emergentalliance.org/calculation-of-the-effective-reproduction-number-germany/ to the allowlist of entries in cypress/integration/hybrid/check_links.js

Verification

npm run test:open
select hybrid/check_links.js in Cypress test runner

The test should run without errors.

@MikeMcC399
Copy link
Contributor Author

Since this issue is no longer reproducible there is no need for a PR.

@MikeMcC399 MikeMcC399 closed this Oct 30, 2022
@MikeMcC399
Copy link
Contributor Author

This fix is needed after all, since the issue appears sporadically.

@MikeMcC399 MikeMcC399 reopened this Oct 30, 2022
@dsarkar
Copy link
Member

dsarkar commented Oct 30, 2022

@MikeMcC399 Thanks for the PR.

@dsarkar dsarkar merged commit 7105d0f into corona-warn-app:master Oct 30, 2022
@MikeMcC399 MikeMcC399 deleted the fix/cypress-timeout branch October 30, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants