Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list termination in FAQ error_log #3230

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Fix list termination in FAQ error_log #3230

merged 3 commits into from
Nov 23, 2022

Conversation

MikeMcC399
Copy link
Contributor

This PR resolves issue #3229 "Wrongly terminated list in FAQ #error_log"

In the first unordered list (<ul>) in

the order of the closing tags is corrected to be </li></ul>.

@MikeMcC399 MikeMcC399 requested a review from a team November 18, 2022 14:45
@MikeMcC399 MikeMcC399 mentioned this pull request Nov 18, 2022
Closed
@brianebeling brianebeling self-assigned this Nov 22, 2022
@brianebeling brianebeling added bug Something isn't working faq labels Nov 22, 2022
MohamedZaghdoudi
MohamedZaghdoudi reviewed Nov 23, 2022
View reviewed changes
Copy link
Contributor

@MohamedZaghdoudi MohamedZaghdoudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399 Thank you for your deep search.

brianebeling
brianebeling approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@brianebeling brianebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@brianebeling brianebeling linked an issue Nov 23, 2022 that may be closed by this pull request
Wrongly terminated list in FAQ #error_log #3229
Closed
@MikeMcC399
Copy link
Contributor Author

The checks are failing due to a network error:

npm ERR! URL: https://download.cypress.io/desktop/10.11.0?platform=linux&arch=x64
npm ERR! Error: Failed downloading the Cypress binary.
npm ERR! Response code: 524

@brianebeling
Copy link
Member

brianebeling commented Nov 23, 2022 •
edited
Loading

The checks are failing due to a network error:

npm ERR! URL: https://download.cypress.io/desktop/10.11.0?platform=linux&arch=x64
npm ERR! Error: Failed downloading the Cypress binary.
npm ERR! Response code: 524

That is weird. Error 5XX are usually not on our end. I will try again in a bit.

@brianebeling brianebeling merged commit 6f29358 into corona-warn-app:master Nov 23, 2022
@MikeMcC399 MikeMcC399 deleted the fix/error_log-list branch November 23, 2022 17:04
@MohamedZaghdoudi MohamedZaghdoudi mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedZaghdoudi MohamedZaghdoudi MohamedZaghdoudi left review comments

@brianebeling brianebeling brianebeling approved these changes

Assignees

@brianebeling brianebeling

Labels
bug Something isn't working faq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrongly terminated list in FAQ #error_log
3 participants
@MikeMcC399 @brianebeling @MohamedZaghdoudi