Science blog 6 (German)

[brifemu]

PR to implement Science Blog 6 (German)

[MikeMcC399]

I've made some comments:

1. Typos + one instance where I wasn't sure about the sentence.
2. German abbreviations need a space in them (see DIN 5008).
3. The link using ../ doesn't work. I suggest to use /de/science instead. Also you should check that the Cypress test npm test runs without errors.
4. I mentioned also about the <figcaption> use not being compliant.

[Ein-Tim]

Three comments.

[brianebeling]

I resolved the remaining suggestions - thanks! - and will hopefully commit those (visibly) next week. Right now they are on a fork of a fork, but I can't push directly and have to wait for @brifemu to accept the PR.

[mtb77]

@Ein-Tim feel free to have a final look at the changes :)

[Ein-Tim]

@mtb77 Will do so & provide feedback in ca. 60 minutes. Hope that's ok for you?

[mtb77]

@Ein-Tim sure, no rush. We would like to publish it Wednesday.

[MikeMcC399]

• npm run test:open with check_anchor_links test success
• npm test success
• https://validator.w3.org/ on local public\de\science\2022-11-23-science-blog-6\index.html
  Only error is due to unrelated issue Incorrect placing of screen-reader text in navigation #3225

[MikeMcC399]

Apart from one missing comma, this PR is good to go!

[Ein-Tim]

Some comments.

[MikeMcC399]

It looks good to publish now!

[Ein-Tim]

Looks good now! Great work everybody, this was a really interesting read!

[MikeMcC399]

It would be good in future to squash commits either before merging or as part of the merge. Otherwise the commit history in the master branch is much too detailed and is very untidy. There are 22 commits in this PR and they have each gone into the master branch individually instead of as just one consolidated commit. 🙁

See

• https://github.com/corona-warn-app/cwa-website/blob/master/CONTRIBUTING.md#pull-request-checklist
• https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/managing-commits/squashing-commits
• https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits

[MikeMcC399]

There is a working branch https://github.com/corona-warn-app/cwa-website/commits/pr/3243 related to this PR in this repository. Can the branch pr/3243 be deleted now that the PR is merged?

[HelTob]

Hello everyone,

also from our side many thanks for your great work.
It makes us happy again and again to see with how much passion you work on our articles.

Keep up the good work and best regards,
Tobias

[MikeMcC399]

Hi Tobias @HelTob !

It's also good to see how very useful the data donation has been and to see that you can show the usefulness of CWA exposure notification.

[MikeMcC399]

@larswmh

There is an old unused branch pr/3243. Could you take a look to see if it can be deleted?

[larswmh]

@MikeMcC399

Thanks for the information. I have deleted the branch.

[MikeMcC399]

@larswmh

Thank you for cleaning up!