Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace child main in faq by div section #3265

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Replace child main in faq by div section #3265

merged 3 commits into from
Dec 1, 2022

Conversation

MikeMcC399
Copy link
Contributor

This PR resolves issue #3264 "Nested main element in faq".

The child main element is converted to a div element. At the same time, a stray </div> end tag is cleaned up.

Since the indenting was not correct and therefore hard to read, I added a second commit with a combination of automatic and manual reformatting.

View commit 20abd0b to look at the changes which are not caused by reformatting.

Verification

Run https://validator.w3.org/ on https://www.coronawarn.app/en/faq/ and the following error messages should no longer appear:

  • "The main element must not appear as a descendant of the main element."
  • "A document must not include more than one visible main element"
  • "Stray end tag div."

@MikeMcC399 MikeMcC399 requested a review from a team November 30, 2022 13:37
@brianebeling brianebeling linked an issue Dec 1, 2022 that may be closed by this pull request
@brianebeling brianebeling added the bug Something isn't working label Dec 1, 2022
Copy link
Member

@brianebeling brianebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no observable errors and validation runs fine. Thanks!

@brianebeling brianebeling merged commit 4098361 into corona-warn-app:master Dec 1, 2022
@MikeMcC399 MikeMcC399 deleted the fix/faq-main branch December 1, 2022 07:27
MohamedZaghdoudi pushed a commit that referenced this pull request Dec 1, 2022
Co-authored-by: Brian-J. Ebeling <github@brianebeling.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested main element in faq
2 participants