Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WRITE_BLOG_POSTS.md for images #3270

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Update WRITE_BLOG_POSTS.md for images #3270

merged 2 commits into from
Dec 2, 2022

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Dec 1, 2022 •
edited
Loading

This PR resolves issue #3269 "Incorrect guidance in WRITE_BLOG_POSTS for images"

It updates the document WRITE_BLOG_POSTS.md.

  1. The example is converted to use class="text-center"
  2. A link to the bootstrap documentation is added
  3. The non-working code to show an image on GitHub is removed. The syntax for GitHub and the cwa-website are different, so it is not useful to attempt to display an image in the GitHub document.

To easily view the changed document when reviewing, open https://github.com/MikeMcC399/cwa-website/blob/fix/blog-post-doc-guide/docs/WRITE_BLOG_POSTS.md.

@MikeMcC399 MikeMcC399 requested a review from a team December 1, 2022 12:48
@MikeMcC399 MikeMcC399 mentioned this pull request Dec 1, 2022
Closed
Ein-Tim
Ein-Tim approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@Ein-Tim Ein-Tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianebeling brianebeling linked an issue Dec 2, 2022 that may be closed by this pull request
Incorrect guidance in WRITE_BLOG_POSTS for images #3269
Closed
@brianebeling brianebeling self-assigned this Dec 2, 2022
@brianebeling brianebeling added the bug Something isn't working label Dec 2, 2022
brianebeling
brianebeling approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@brianebeling brianebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with documentation. Adding the documentation link was a nice touch!

@brianebeling brianebeling added documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 2, 2022
@brianebeling brianebeling merged commit a0f5737 into corona-warn-app:master Dec 2, 2022
@MikeMcC399 MikeMcC399 deleted the fix/blog-post-doc-guide branch December 2, 2022 06:39
@MohamedZaghdoudi MohamedZaghdoudi mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianebeling brianebeling brianebeling approved these changes

@Ein-Tim Ein-Tim Ein-Tim approved these changes

Assignees

@brianebeling brianebeling

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect guidance in WRITE_BLOG_POSTS for images
3 participants
@MikeMcC399 @brianebeling @Ein-Tim