Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove role="main" from layout files #3271

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Remove role="main" from layout files #3271

merged 1 commit into from
Dec 2, 2022

Conversation

MikeMcC399
Copy link
Contributor

This PR resolves issue #3266 "main role (ARIA) not recommended."

The attribute declaration role="main" is removed from layout html files in src/layouts

Verification

Run https://validator.w3.org/ on

https://www.coronawarn.app/en/faq/ and ensure that the following warning message does not appear:

"The main role is unnecessary for element main."

Also check:

and select "Validate error pages" before clicking on "Check".

@MikeMcC399 MikeMcC399 requested a review from a team December 1, 2022 13:23
@brianebeling brianebeling self-assigned this Dec 2, 2022
@brianebeling brianebeling added the bug Something isn't working label Dec 2, 2022
@brianebeling brianebeling linked an issue Dec 2, 2022 that may be closed by this pull request
@brianebeling
Copy link
Member

Thank you very much, as always 😄

@brianebeling brianebeling merged commit 9d74e77 into corona-warn-app:master Dec 2, 2022
@MikeMcC399 MikeMcC399 deleted the fix/main-role-removal branch December 2, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

main role (ARIA) not recommended
2 participants