Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump copyright year in README.md #3299

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

Ein-Tim
Copy link
Contributor

@Ein-Tim Ein-Tim commented Jan 1, 2023

Description

This PR bumps the copyright year in the README.md file.

Happy new year! 🎉

Note

This PR should only be merged once a change to any content of this repository was done.


Internal Tracking ID: EXPOSUREAPP-14521

This commit bumps the copyright year in the README.md file.
@Ein-Tim Ein-Tim requested a review from a team January 1, 2023 01:41
Copy link
Member

@brianebeling brianebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in the other PRs of the same kind already, thanks for the change. I was unable to find more places that would require a change.

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jan 2, 2023

@brianebeling

Same as in the other PRs of the same kind already, thanks for the change. I was unable to find more places that would require a change.

Happy New Year!

What about https://github.com/corona-warn-app/cwa-website/blob/master/NOTICE? I don't know if this file even makes sense in fact.

There are various opinions on the Internet about whether it is legally necessary to update Copyright notices on websites or not. That would be a question for the lawyers. It does however give readers an idea about whether the website is up-to-date or not.

@dsarkar dsarkar self-assigned this Jan 2, 2023
@dsarkar dsarkar added the documentation Improvements or additions to documentation label Jan 2, 2023
@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Jan 2, 2023

@MikeMcC399 To me, it looks like the NOTICE file of this repository was never correctly established. When comparing the file from this repository to the file in the documentation repository , it looks like the contributors are missing. But also there, in the documentation repo, the copyright year has never been changed. I'm unsure if this file is really relevant.

@brianebeling
Copy link
Member

brianebeling commented Jan 2, 2023

Honestly, I'm not sure. I will forward it and let you know.

I'd suggest we merge this and make a separate PR for the notice.

Also Happy New Year to both of you. I will be on vacation for around two weeks and only check in here irregularly, but @dsarkar is back in action. 🎉

@MikeMcC399
Copy link
Contributor

@Ein-Tim / @brianebeling

https://www.apache.org/licenses/LICENSE-2.0 in the section "HOW TO APPLY THE APACHE LICENSE TO YOUR WORK" says:
"Include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file that references the License."

however since the suggested text is already in the README, Licensing section and NOTICE is incorrectly completed, then I suggest that the NOTICE file is deleted as part of any Copyright update review.

Copy link
Member

@larswmh larswmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Ein-Tim!

I'd like to merge this now that we've had a change to the FAQ. The concerns about the NOTICE file have been forwarded and we will take action if necessary, thanks for the information @MikeMcC399.

@larswmh larswmh merged commit e93fb10 into corona-warn-app:master Jan 2, 2023
@MikeMcC399
Copy link
Contributor

@larswmh

If the README only refers to itself:

"Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License."

and the NOTICE file refers to "them" without specifying what "them" means as in:

"you may not use them except in compliance with the License."

then this should be cleaned up.

My reading of opinions about Copyright notices says that they are not really necessary, so if they are not necessary, then it doesn't matter if they are clean or not, however this should be sorted out by legal experts.

Thank for passing on the concerns in any case.

@Ein-Tim Ein-Tim deleted the bump/copyright-year-README branch January 2, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation mirrored-to-jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants