Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows: Include build job into build-and-test #3324

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

larswmh
Copy link
Member

@larswmh larswmh commented Jan 13, 2023

This PR modifies the build-and-test.yml workflow so that it includes two jobs:

  • build: the required job to merge PRs into master
  • test: the optional job to test PRs with Cypress

Internal Tracking ID: EXPOSUREAPP-14535

@larswmh larswmh merged commit df2d645 into master Jan 13, 2023
@larswmh larswmh deleted the update/workflows-build-and-test branch January 13, 2023 08:56
@MikeMcC399
Copy link
Contributor

@larswmh

It's interesting to see in #3323 that the "build" job is required and the "test" job is not required. Again, I'm guessing that this is part of the branch protection rules which are not visible to me.

image

@larswmh
Copy link
Member Author

larswmh commented Jan 13, 2023

@MikeMcC399

It's interesting to see in #3323 that the "build" job is required and the "test" job is not required. Again, I'm guessing that this is part of the branch protection rules which are not visible to me.

image

In the branch protection rules, the build job is set as required. Not the build.yml workflow file. This way I could just move the job to the build-and-test.yml without problems.
image

@MikeMcC399
Copy link
Contributor

@larswmh

Thank you for the screenshot! I imagined that it must be like this, however I had no way to view it.

It might be good at a later stage to add the test job to the required positive status outcomes. It is probably good for the moment not to require it, until there is more experience with the job. Whoever merges a PR can make the decision manually if they want to merge a PR which fails the Cypress test (like #3321).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants