Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMH Benchmarking Fixups #413

Closed
wants to merge 0 commits into from
Closed

JMH Benchmarking Fixups #413

wants to merge 0 commits into from

Conversation

geedo0
Copy link
Contributor

@geedo0 geedo0 commented Dec 20, 2024

Issue #, if available:
ACCP-118

Description of changes:
These changes intend to improve the consistency and freshness of the JMH
benchmarks to support better reporting.

  • Upgrade the BouncyCastle dependency to the latest jdk18on artifact.
    The artifact we were previously using has not seen an update in 3
    years.
  • Remove the ms TimeUnit override for AES-XTS. This is the only
    benchmark that does this and breaks uniformity across the suite.
  • Update Random's TimeUnit to microseconds. Nanosecond precision is not
    supported by CloudWatch and the ns precision is not strictly
    necessary.
  • Fix some misnamed benchmark names.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@geedo0 geedo0 requested a review from a team as a code owner December 20, 2024 19:33
@geedo0 geedo0 closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant