Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add support to clip from disk #226

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Jan 29, 2021

Related: #222, #207

Notes:

  • This was originally going to be added to rioxarray.open_rasterio, but with the various options for clipping, I thought this made more sense.
  • Made from_disk optional and turned off by default as I am thinking it likely won't work well with dask. Also, it seems to add a buffer of nodata on the edge for some reason.

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #226 (c9a2079) into master (d63e5e2) will decrease coverage by 0.19%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   92.15%   91.96%   -0.20%     
==========================================
  Files          11       11              
  Lines        1287     1306      +19     
==========================================
+ Hits         1186     1201      +15     
- Misses        101      105       +4     
Impacted Files Coverage Δ
rioxarray/_io.py 87.50% <ø> (ø)
rioxarray/raster_array.py 96.85% <93.10%> (-1.28%) ⬇️
rioxarray/raster_dataset.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63e5e2...7beb7a5. Read the comment docs.

@snowman2 snowman2 merged commit 8beb1c7 into corteva:master Jan 29, 2021
@snowman2 snowman2 deleted the clip_disk branch January 29, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mask & bbox arguments to open_rasterio
2 participants