Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix indexing error when mask_and_scale=True was combined with band dim chunking #388

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

fbunt
Copy link
Contributor

@fbunt fbunt commented Aug 3, 2021

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #388 (a927e51) into master (008c2a2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   95.86%   95.85%   -0.01%     
==========================================
  Files          13       13              
  Lines        1474     1473       -1     
==========================================
- Hits         1413     1412       -1     
  Misses         61       61              
Impacted Files Coverage Δ
rioxarray/_io.py 95.12% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008c2a2...a927e51. Read the comment docs.

@snowman2
Copy link
Member

snowman2 commented Aug 3, 2021

The latest test failure can be ignored. This looks good, thanks @fbunt 👍. Any issues if I squash and merge?

@snowman2 snowman2 changed the title Fix issue 387 BUG: Fix indexing error when mask_and_scale=True was combined with band dim chunking Aug 3, 2021
@fbunt
Copy link
Contributor Author

fbunt commented Aug 3, 2021

Great! Nope, squash away

@snowman2 snowman2 merged commit 838e7e8 into corteva:master Aug 3, 2021
@snowman2
Copy link
Member

snowman2 commented Aug 3, 2021

Thanks @fbunt 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError on compute() when using mask_and_scale=True and dask chunking along band dimension
3 participants