Avoiding DeprecationWarning: xr.Dataset.drop() -> xr.Dataset.drop_vars() #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowman2
reviewed
Feb 7, 2024
| @@ -881,7 +881,7 @@ def _load_bands_as_variables( | |||
| **open_kwargs, | |||
| ) | |||
| .squeeze() # type: ignore | |||
There was a problem hiding this comment.
Suggested change
| .squeeze() # type: ignore | |
| .squeeze(dim="band", drop=True) # type: ignore |
snowman2
reviewed
Feb 7, 2024
| @@ -881,7 +881,7 @@ def _load_bands_as_variables( | |||
| **open_kwargs, | |||
| ) | |||
| .squeeze() # type: ignore | |||
| .drop("band") # type: ignore | |||
| .drop_vars("band") # type: ignore | |||
There was a problem hiding this comment.
Suggested change
| .drop_vars("band") # type: ignore |
|
Thank you @xaviernogueira! I suggested a different approach that could prevent squeezing out dimensions we don't intend while also resolving this issue. Mind testing it out and seeing if it solves the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple PR. I was getting deprecation warnings from
rioxarraythat originated inxarray. Here is an example of the warning:So I simply went in and changed it. I don't have time to recreate the full dev environment, but it should work. That said, maybe someone should probably re-run you're test suite before merging. I can do it, but most likely a few days from now.