topic/EM-1417: Add Methods for Charts Widget Data Access #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKwenhua
requested review from
toastercup,
arelia,
mrfantasticwonders and
ElliottAYoung
mrfantasticwonders
approved these changes
May 23, 2017
ElliottAYoung
approved these changes
May 23, 2017
There was a problem hiding this comment.
Approved - but quick note @MKwenhua: Could you please update the README to include the new methods on Webpage, just add them to the table we've got of Webpage attributes
arelia
approved these changes
May 24, 2017
toastercup
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to:
Cortex: cortex-cms/cortex#500
Employer: