Skip to content

EM-1049: Table Issues #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2017
Merged

EM-1049: Table Issues #468

merged 1 commit into from
Mar 28, 2017

Conversation

toastercup
Copy link
Member

@toastercup toastercup commented Mar 27, 2017

Purpose:
This implements the beginnings of a legacy widget system, starting with a 'Tables Widget'. This allows a content creator to input a YAML-formatted set of data in the Webpage 'Widgets' tab.

JIRA:
https://cb-content-enablement.atlassian.net/browse/EM-1049

Changes:

  • Changes to setup

    • N/A
  • Architectural changes

    • N/A
  • Migrations

    • Yes - please run migrations
  • Library changes

    • N/A
  • Side effects

    • Upon deploy to Staging/Production, the Snippets that contained the data used to power dynamic Tables will no longer be available. This data will have to be migrated to the new system. Additionally, PO documentation will need to be updated.

Screenshots

  • Before
    N/A

  • After
    image

QA Links:

How to Verify These Changes

  • Specific pages to visit

    • N/A
  • Steps to take

    • Edit/Create a Webpage on Cortex (use the QA link with admin@cortexcms.org/welcome1 credentials) with an applicable Tables Widget (for example, http://web.employer-4.development.c66.me/portal/EPWHG)
    • Try inputting some example YAML data in the Widgets tab. For example, for an APS page:
---
aps:
- section_heading: A Product Table
  items_heading: Items
  price_heading: Price
  products:
  - name: Item A1
    description: This is a description of Item A!
    price: 42
    cart_url: https://employer.careerbuilder.com/ecommerce/global/addtocart.aspx
    value: Save $10!
  - name: Item B1
    description: This is a nifty description of Item B!
    price: 43
    cart_url: https://employer.careerbuilder.com/ecommerce/global/addtocart.aspx
  - name: Item B1
    description: This is a nifty description of Item B!
    price: 43
    cart_url: https://employer.careerbuilder.com/ecommerce/global/addtocart.aspx
- section_heading: Another Product Table
  items_heading: Items
  price_heading: Price
  products:
  - name: Item A2
    description: This is a description of Item A!
    price: 42
    cart_url: https://employer.careerbuilder.com/ecommerce/global/addtocart.aspx
    value: Save $10!
  - name: Item B2
    description: This is a nifty description of Item B!
    price: 43
    cart_url: https://employer.careerbuilder.com/ecommerce/global/addtocart.aspx
  • Or for an eCom Promotions page:
---
products:
- section_heading: A Promotions Table
  items_heading: Items
  price_heading: Price
  products:
  - name: Item A1
    description: This is a description of Item A!
    price: 42
    cart_url: https://employer.careerbuilder.com/ecommerce/global/addtocart.aspx
    value: Save $10!
  • Save!

  • Witness that the Table now appears on the page

  • Try breaking the table with some invalid YAML

  • Witness that the page still renders, but with a Table that produces an error

  • Responsive considerations

    • N/A

Relevant PRs/Dependencies:
https://github.com/cbdr/employer/pull/736
cortex-cms/cortex-snippets-client-ruby#29

Additional Information
N/A

Copy link
Contributor

@MKwenhua MKwenhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍

@toastercup toastercup merged commit 7a4f632 into develop Mar 28, 2017
@toastercup toastercup deleted the bugfix/EM-1049-Table-Issues branch March 28, 2017 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants