Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up the searching/validating processes of models on the serving container #1663

Closed
RobertLucian opened this issue Dec 7, 2020 · 0 comments · Fixed by #1690
Closed
Assignees
Labels
performance A performance improvement
Milestone

Comments

@RobertLucian
Copy link
Member

RobertLucian commented Dec 7, 2020

Description

When an API with many models is deployed (when using the predictor.models.dir field), the searching and validating processes of the models is very slow - so slow, that for a large number of models (i.e. 1000), it takes > 10 minutes to run it once.

The 2 culprit functions for that are validate_models_dir_paths and find_all_cloud_models, with the former taking the most amount of time.

A good example of this is the translator example #1592.

Motivation

Apart from taking a lot of time to update the models' tree once, it's also the CPU that's wasted in the process. This needs to be faster.

Reason

Most likely a complexity problem.

@RobertLucian RobertLucian added the performance A performance improvement label Dec 7, 2020
@RobertLucian RobertLucian added this to the v0.25 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant