Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing API still "updating" in cortex get #1680

Closed
RobertLucian opened this issue Dec 10, 2020 · 0 comments · Fixed by #1691
Closed

Failing API still "updating" in cortex get #1680

RobertLucian opened this issue Dec 10, 2020 · 0 comments · Fixed by #1691
Assignees
Labels
bug Something isn't working
Milestone

Comments

@RobertLucian
Copy link
Member

RobertLucian commented Dec 10, 2020

Version

>= 0.23

Description

When an API is failing getting started (due to an exception in the predictor's constructor), the deployment enters a restart loop (as described by the API's deployment spec), but the API's state doesn't change in cortex get (or in the Python Client). The API's state is stuck to updating as opposed to switching to error or to anything else as expected.

Steps to reproduce

Take an iris classifier test example and add a raise in the constructor. Deploy that using any cloud provider (AWS or GCP). Then check cortex get and notice how the API's state doesn't change from updating to error.

Solution

When creating a stage 2 service with s6, if a service exits with a non-zero exit code, before sending the kill signal to all other services, export the non-zero exit code to stage 3 like in this example.

... redirfd -w 1 /var/run/s6/env-stage3/S6_STAGE2_EXITED s6-echo -n -- \${1} ...
@RobertLucian RobertLucian added the bug Something isn't working label Dec 10, 2020
@RobertLucian RobertLucian changed the title Failing pod still "updating" in cortex get Failing API still "updating" in cortex get Dec 10, 2020
@deliahu deliahu added this to the v0.25 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants