Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support typical image request format(s) #332

Closed
deliahu opened this issue Aug 14, 2019 · 0 comments · Fixed by #1062
Closed

Support typical image request format(s) #332

deliahu opened this issue Aug 14, 2019 · 0 comments · Fixed by #1062
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@deliahu
Copy link
Member

deliahu commented Aug 14, 2019

E.g. multi-part image requests

When moving body and form params into the payload object, also consider adding query params

Related to #546 if the solution here is to expose form data in the handers/predictor

Notes

# multi-part form
curl -F 'image=@dog.jpg' 'http://a276ec846ff2211e9b92c0a56b992336-830038469.us-west-2.elb.amazonaws.com/iris/classifier?debug=true&test=2'

# form
curl -F 'image=test' 'http://a276ec846ff2211e9b92c0a56b992336-830038469.us-west-2.elb.amazonaws.com/iris/classifier?debug=true&test=2'
logger.info(request.args)  # query params
logger.info(request.form)  # form
logger.info(request.files)  # multi-part form
@deliahu deliahu added enhancement New feature or request v0.8 and removed v0.8 labels Aug 14, 2019
@deliahu deliahu added v0.8 and removed v0.9 labels Aug 30, 2019
@deliahu deliahu added v0.9 and removed v0.8 labels Sep 13, 2019
@deliahu deliahu changed the title Support multi-part image requests Support alternative image request formats Sep 24, 2019
@deliahu deliahu changed the title Support alternative image request formats Support typical image request format(s) Sep 24, 2019
@vishalbollu vishalbollu added v0.10 and removed v0.9 labels Oct 7, 2019
@deliahu deliahu changed the title Support typical image request format(s) Support typical image request format(s) [1] Oct 11, 2019
@deliahu deliahu added research Determine technical constraints and removed v0.10 labels Oct 11, 2019
@deliahu deliahu changed the title Support typical image request format(s) [1] Support typical image request format(s) Nov 5, 2019
@deliahu deliahu removed the research Determine technical constraints label Nov 5, 2019
@deliahu deliahu added the v0.17 label May 14, 2020
@deliahu deliahu self-assigned this May 14, 2020
@deliahu deliahu added this to the v0.17 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants