Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve API Readiness check #786

Closed
vishalbollu opened this issue Jan 29, 2020 · 0 comments · Fixed by #788
Closed

Improve API Readiness check #786

vishalbollu opened this issue Jan 29, 2020 · 0 comments · Fixed by #788
Labels
bug Something isn't working

Comments

@vishalbollu
Copy link
Contributor

Version

v0.13

Description

Pod readiness check has two components, watching for a health check file and ensuring that the python process is still running. The check ensuring that the python process is still running is incorrect because it checks for api.py instead of serve.py. The process check may be returning true regardless of whether the process is running or not.
@vishalbollu vishalbollu added the bug Something isn't working label Jan 29, 2020
@vishalbollu vishalbollu mentioned this issue Jan 29, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve healthcheck cortexlabs/cortex
1 participant
@vishalbollu