Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve healthcheck #788

Merged
merged 4 commits into from
Jan 29, 2020
Merged

Improve healthcheck #788

merged 4 commits into from
Jan 29, 2020

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jan 29, 2020 •
edited
Loading

closes #786

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • cherry-pick into release branches if applicable

@vishalbollu vishalbollu requested a review from deliahu January 29, 2020 20:08
@deliahu deliahu changed the title Improve healthcheck and at version assertion before parsing args Improve healthcheck Jan 29, 2020
@vishalbollu vishalbollu merged commit cb95e2f into master Jan 29, 2020
@vishalbollu vishalbollu deleted the improve-health-check branch January 29, 2020 20:24
deliahu pushed a commit that referenced this pull request Jan 29, 2020
@vishalbollu @deliahu
Improve healthcheck (#788)
58b17d3 
(cherry picked from commit cb95e2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve API Readiness check
2 participants
@vishalbollu @deliahu