Skip to content

Support requirements.sh to install system dependencies #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deliahu opened this issue Mar 4, 2020 · 2 comments · Fixed by #880
Closed

Support requirements.sh to install system dependencies #844

deliahu opened this issue Mar 4, 2020 · 2 comments · Fixed by #880
Labels
enhancement New feature or request
Milestone

Comments

@deliahu
Copy link
Member

deliahu commented Mar 4, 2020

Description

Allow the user to provide a top-level requirements.sh file (it could be named something else), in which they can install system dependencies.

Motivation

Some dependencies must be installed via apt or via conda

Things to check

  • Would this support running in a conda environment?
  • chmod +x if necessary

Things to document

  • Users would need to run apt-get update before apt-get install
  • Building your own image will lead to faster API startup times
@deliahu deliahu added the enhancement New feature or request label Mar 4, 2020
@RobertLucian
Copy link
Member

Would this support running in a conda environment?

If conda/pip packages are to be installed in this script, then I think this should run by-default in a conda environment. My 2 cents.

@deliahu
Copy link
Member Author

deliahu commented Mar 6, 2020

@RobertLucian I just created #852 to track our research into a conda environment separately from this (which can be use primarily for e.g. apt-get install)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants