Support conda packages & script.sh for system dependencies #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobertLucian Thanks for the PR! The features improvements addressed in this PR will make customizing Cortex runtime a lot easier and minimize the need for users to create custom Docker images. We are currently focused on bug fixes and messaging improvements this week. Do you mind if we place the PR on the backburner for the next few days while we focus on this release? |
|
@vishalbollu totally. Take as much time as necessary to sort out things for |
vishalbollu
suggested changes
Mar 30, 2020
vishalbollu
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #844 and closes #852.
This includes support for conda packages (
environment.yamlorconda-packages.txt+.condarcfor conda config) and system dependencies installable at run-time (script.sh).The deployment docs have been updated to include these. I'd say, the serving images are slightly bigger than before. I've seen an increase in size of about ~100-250 MB for the serving images - I think that's okay.
Keeping out all dependencies of each serving image and instead, have them baked into the image once there is a deployment and then push them to ECR for later use might seem like a better idea.
checklist:
make testandmake lintsummary.md(view in gitbook after merging)