Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow predictor base images to be overridden in API configuration #900

Closed
deliahu opened this issue Mar 23, 2020 · 1 comment · Fixed by #948
Closed

Allow predictor base images to be overridden in API configuration #900

deliahu opened this issue Mar 23, 2020 · 1 comment · Fixed by #948
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@deliahu
Copy link
Member

deliahu commented Mar 23, 2020

Motivation

  • Different APIs may benefit from having different base images
  • Allow rolling updates when updating the base image

Design

Add a top-level key under predictor image

- name: iris-classifier
   predictor:
    type: python
    path: predictor.py
    image: ecr/dockerhub link
  • image defaults to cortex default images if user doesn't specify key
  • validate that the image path, check access to image (prioritize DockerHub, we may be able to add ECR later)
@deliahu deliahu added enhancement New feature or request v0.16 labels Mar 23, 2020
@RobertLucian
Copy link
Member

RobertLucian commented Mar 27, 2020

Per our last conversation, I'm grabbing this ticket. Thanks @vishalbollu !

Useful articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants