Skip to content

Remove user-facing images from cluster.yaml #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobertLucian opened this issue Apr 7, 2020 · 4 comments
Closed

Remove user-facing images from cluster.yaml #950

RobertLucian opened this issue Apr 7, 2020 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@RobertLucian
Copy link
Member

RobertLucian commented Apr 7, 2020

Description

Move docker image paths from cluster.yaml to cortex.yaml. Thanks, @deliahu, and @vishalbollu for thinking about this.

Motivation

Since #900 allows setting images on a per-API basis, keeping the afferent fields in the cluster config doesn't make much sense, because, at this idea's core, images are supposed to be set on an API basis.

The other advantage of setting them in the API is that the user has more granular control over what API uses what resource. And regardless, if users leave the fields empty (in the API config), they will get the default paths anyway.

@RobertLucian RobertLucian added the enhancement New feature or request label Apr 7, 2020
@deliahu deliahu added the v0.16 label Apr 7, 2020
@deliahu
Copy link
Member

deliahu commented Apr 7, 2020

@RobertLucian I think we may want to fold this into #900, what do you think?

@RobertLucian
Copy link
Member Author

RobertLucian commented Apr 7, 2020

@deliahu Hmm, so you're saying this ticket should be closed and have the description added to #900? I agree - this ticket is tied to #900.

@deliahu
Copy link
Member

deliahu commented Apr 8, 2020

Keeping it as a separate ticket is totally ok! I was just thinking #900 should close both 👍 (which it sounds like your were too)

@RobertLucian
Copy link
Member Author

Oh yeah, definitely. Both of them are gonna be closed at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants