Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccessible python packages after Python update w/ Conda #1052

Merged
merged 4 commits into from
May 11, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented May 10, 2020

Closes #1051.

When conda-packages.txt is used to update Python to a different version (major.minor version), all packages that were previously installed on the image will no longer be accessible. This is not because they are removed, but because they reside in a different folder named after the Python's version.

Since most packages are built for each major.minor version of Python, it's just better to reinstall them if a change of version is detected. This is something that should definitely not be encouraged, because it may very well break the web server. The web server is currently running on Python 3.6.9. By moving it to a different version, its stability cannot be guaranteed.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update docs and add any new files to summary.md (view in gitbook after merging)

@deliahu deliahu requested a review from vishalbollu May 10, 2020 02:39
@deliahu
Copy link
Member

deliahu commented May 10, 2020

This is great @RobertLucian, thanks for adding this!

It looks good to me, and I've added @vishalbollu as a reviewer since he has been more involved with this part of the code, and he can go ahead and merge if it looks good to him

@RobertLucian
Copy link
Member Author

RobertLucian commented May 10, 2020

@deliahu just tested this with the latest and it works. It's a go from me.

Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for getting to this so quickly.

@vishalbollu vishalbollu merged commit 32343f2 into cortexlabs:master May 11, 2020
@RobertLucian RobertLucian deleted the bugfix/missing-core-pkgs branch May 11, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding certain pip and/or conda packages removes pre-installed packages
3 participants