Skip to content

Call __init__() from request thread pool #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Call __init__() from request thread pool #1146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9a7dbe
Call __init__() from request thread pool
deliahu Jun 20, 2020
1d2c98c
Merge branch 'master' of github.com:cortexlabs/cortex into thread-pool
deliahu Jun 24, 2020
b3d4957
Merge branch 'master' of github.com:cortexlabs/cortex into thread-pool
deliahu Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pkg/workloads/cortex/serve/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,9 @@
API_LIVENESS_UPDATE_PERIOD = 5 # seconds


request_thread_pool = ThreadPoolExecutor(max_workers=int(os.environ["CORTEX_THREADS_PER_PROCESS"]))
loop = asyncio.get_event_loop()
loop.set_default_executor(
ThreadPoolExecutor(max_workers=int(os.environ["CORTEX_THREADS_PER_PROCESS"]))
)
loop.set_default_executor(request_thread_pool)

app = FastAPI()

Expand Down Expand Up @@ -239,7 +238,15 @@ def get_summary():
return response


# this exists so that the user's __init__() can be executed by the request thread pool, which helps
# to avoid errors that occur when the user's __init__() function must be called by the same thread
# which executes predict(). This only avoids errors if threads_per_worker == 1
def start():
future = request_thread_pool.submit(start_fn)
return future.result()


def start_fn():
cache_dir = os.environ["CORTEX_CACHE_DIR"]
provider = os.environ["CORTEX_PROVIDER"]
spec_path = os.environ["CORTEX_API_SPEC"]
Expand Down