Skip to content

Add .env to export environment variables #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 23, 2020
Merged

Add .env to export environment variables #1154

merged 6 commits into from
Jun 23, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jun 23, 2020 •
edited
Loading

Closes #1147.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update docs and add any new files to summary.md (view in gitbook after merging)

@RobertLucian RobertLucian added the enhancement New feature or request label Jun 23, 2020
@RobertLucian RobertLucian requested a review from deliahu June 23, 2020 03:19
deliahu
deliahu reviewed Jun 23, 2020
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thank you for adding this!

deliahu
deliahu approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

deliahu
deliahu approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertLucian RobertLucian merged commit f155100 into master Jun 23, 2020
@RobertLucian RobertLucian deleted the feature/env-file-api branch June 23, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to export environment variables with .env file
2 participants
@RobertLucian @deliahu