Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cortex verification from serve.py to run.sh #1180

Merged
merged 2 commits into from
Jun 28, 2020

Conversation

vishalbollu
Copy link
Contributor

Catch image version mismatch earlier so to make errors such as #1178 easier to debug for users who've created custom images.

Since start_uvicorn.py has quite a bit of application code, the image version verification should happen before start_uvicorn.py is run.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

Sorry, something went wrong.

@vishalbollu vishalbollu merged commit 5fb3d65 into master Jun 28, 2020
@vishalbollu vishalbollu deleted the version-verification-bash branch June 28, 2020 23:32
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw the review request notification now. Even though this has been merged, I can say this LGTM. Makes sense to place the verification outside the Python script.

deliahu added a commit that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants