Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recursive error message for deploy/delete CLI commands #1247

Merged
merged 14 commits into from
Aug 14, 2020
Merged

Fix recursive error message for deploy/delete CLI commands #1247

merged 14 commits into from
Aug 14, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jul 31, 2020 •
edited
Loading

Fixes #1218.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Jul 31, 2020
@RobertLucian RobertLucian requested a review from vishalbollu July 31, 2020 23:27
vishalbollu
vishalbollu reviewed Aug 13, 2020
View reviewed changes
@vishalbollu vishalbollu self-requested a review August 13, 2020 13:21
vishalbollu
vishalbollu reviewed Aug 14, 2020
View reviewed changes
vishalbollu
vishalbollu approved these changes Aug 14, 2020
View reviewed changes
@RobertLucian RobertLucian merged commit fd7f0a7 into master Aug 14, 2020
@RobertLucian RobertLucian deleted the fix/unrecoverable-version-mismatch-error branch August 14, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalbollu vishalbollu vishalbollu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate validity of error message when re-deploying on a different CLI version
2 participants
@RobertLucian @vishalbollu