Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell completion to .zshrc #1265

Merged
merged 4 commits into from
Aug 19, 2020
Merged

Add shell completion to .zshrc #1265

merged 4 commits into from
Aug 19, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Aug 15, 2020

closes #1221

@deliahu deliahu requested a review from vishalbollu August 15, 2020 17:55
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor nit, LGTM otherwise

get-cli.sh Outdated
fi
fi

if [ "$did_locate_shell_profile" = "false" ]; then
echo -e "\nIf your would like to enable cortex bash completion and the cx alias, run \`cortex completion --help\` for instructions"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If your would -> If you would

@deliahu deliahu merged commit 11bcd88 into master Aug 19, 2020
@deliahu deliahu deleted the zshrc-completion branch August 19, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shell completion to .zshrc instead of .bashrc if using zsh
2 participants